Fix UI flickering when fetching bookings for the first time #14800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `replaceAllForSite` transactional function to the `BookingsDao`. This function first deletes all bookings for a given site and then inserts the new list of bookings, ensuring atomicity.
The `deleteAllForSite` and `insertOrReplace` calls are replaced with a single `replaceAllForSite` call. This is done within a database transaction, making the operation more efficient.
irfano
requested review from
AdamGrzybkowski,
JorgeMucientes and
hichamboushaba
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14800 +/- ##
============================================
- Coverage 38.15% 38.15% -0.01%
+ Complexity 10059 10058 -1
============================================
Files 2129 2129
Lines 120211 120215 +4
Branches 16439 16439
============================================
- Hits 45867 45864 -3
- Misses 69721 69727 +6
- Partials 4623 4624 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdamGrzybkowski
approved these changes
Oct 22, 2025
Contributor
AdamGrzybkowski
left a comment
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Good find @irfano 🔥
AdamGrzybkowski
deleted the
issue/WOOMOB-1559-fux-db-transaction-issue-for-bookings
branch
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1559
Description
When fetching the first page of the bookings list, we were deleting existing bookings and inserting new ones in two separate database transactions. This caused the UI to briefly display an empty list, resulting in flickering. This PR combines these two operations into a single transaction to resolve the issue.
Steps to reproduce
The tests that have been performed
Steps above
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.